Skip to content

Make sure Locative doesn't submit invalid device IDs#20784

Merged
balloob merged 1 commit intodevfrom
slugify-locative
Feb 6, 2019
Merged

Make sure Locative doesn't submit invalid device IDs#20784
balloob merged 1 commit intodevfrom
slugify-locative

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 6, 2019

fixes #20781

@ghost ghost assigned balloob Feb 6, 2019
@ghost ghost added the in progress label Feb 6, 2019
@balloob balloob added this to the 0.87.0 milestone Feb 6, 2019
Copy link
Copy Markdown
Member

@rohankapoorcom rohankapoorcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but we could also do this when voluptuous is processing the webhook by modifying the webhook schema.

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Feb 6, 2019

For 87, let's keep it at this.

@balloob balloob merged commit 65a225d into dev Feb 6, 2019
@ghost ghost removed the in progress label Feb 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the slugify-locative branch February 6, 2019 17:50
@balloob balloob mentioned this pull request Feb 6, 2019
bachya pushed a commit to bachya/home-assistant that referenced this pull request Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Locative with Webhook not working

3 participants