Add support for HomeKit motion sensor devices#20555
Merged
balloob merged 1 commit intohome-assistant:devfrom Jan 29, 2019
Merged
Add support for HomeKit motion sensor devices#20555balloob merged 1 commit intohome-assistant:devfrom
balloob merged 1 commit intohome-assistant:devfrom
Conversation
2 tasks
2 tasks
balloob
approved these changes
Jan 29, 2019
| @property | ||
| def is_on(self): | ||
| """Has motion been detected.""" | ||
| if not self.available: |
Member
There was a problem hiding this comment.
This check isn't necessary. It will be handled by the base entity class.
9 tasks
Member
Author
|
Opened #20568 to make sure this isn't lost. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add support for polling HomeKit motion sensors.
I'm testing with an Eve Motion (on my bluetooth branch) and a homekit_python demoserver accessory based on the HAP spec (page 225). A HomeKit motion sensor will have a service of type
public.hap.service.sensor.motionwith a single required characteristic ofpublic.hap.characteristic.motion-detectedwhich is a bool. The characteristic will be set to true after motion is detected and will return to false after a minute or so with no motion detected. (In the case of the Eve Motion you can tweak this duration in the app).Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8332
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: