Skip to content

Small cleanup of MQTT platforms#20503

Merged
fabaff merged 4 commits intohome-assistant:devfrom
emontnemery:mqtt_refactor
Jan 27, 2019
Merged

Small cleanup of MQTT platforms#20503
fabaff merged 4 commits intohome-assistant:devfrom
emontnemery:mqtt_refactor

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Description:

Small cleanup of MQTT platforms:

  • Move CONF_UNIQUE_ID to mqtt/__init__.py
  • Sort imports

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost assigned fabaff Jan 27, 2019
@fabaff fabaff merged commit 648adcc into home-assistant:dev Jan 27, 2019
@ghost ghost removed the in progress label Jan 27, 2019
@emontnemery emontnemery deleted the mqtt_refactor branch January 28, 2019 16:32
fredrike pushed a commit to fredrike/home-assistant that referenced this pull request Jan 30, 2019
* Move CONF_UNIQUE_ID to init

* Sort imports

* Update ordering
@balloob balloob mentioned this pull request Feb 6, 2019
kellerza pushed a commit to kellerza/ha-core that referenced this pull request Feb 24, 2019
* Move CONF_UNIQUE_ID to init

* Sort imports

* Update ordering
MitschiBoy added a commit to MitschiBoy/Valetudo that referenced this pull request Nov 18, 2019
See https://www.home-assistant.io/docs/mqtt/discovery/ and home-assistant/core#20503
Without unique_id MQTT Discovery isn't working with actual versions of Home Assistant
Hypfer pushed a commit to Hypfer/Valetudo that referenced this pull request Nov 21, 2019
See https://www.home-assistant.io/docs/mqtt/discovery/ and home-assistant/core#20503
Without unique_id MQTT Discovery isn't working with actual versions of Home Assistant
rand256 pushed a commit to rand256/valetudo that referenced this pull request Dec 15, 2019
See https://www.home-assistant.io/docs/mqtt/discovery/ and home-assistant/core#20503
Without unique_id MQTT Discovery isn't working with actual versions of Home Assistant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants