Skip to content

Use more up-to-date version of pyfoscam library#20419

Merged
fabaff merged 3 commits intohome-assistant:devfrom
davidlie:dev
Jan 28, 2019
Merged

Use more up-to-date version of pyfoscam library#20419
fabaff merged 3 commits intohome-assistant:devfrom
davidlie:dev

Conversation

@davidlie
Copy link
Copy Markdown
Contributor

@davidlie davidlie commented Jan 25, 2019

Description:

There are several differnent foscam libraries, all pretty similar. It seems that an old, un-maintained version is currently being used. Just redirecting this to one that is more actively maintained and has some newer bug fixes that I have already tested and confirmed work on my local installation. Should not break any existing installations.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • [] New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @davidlie,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@awarecan
Copy link
Copy Markdown
Contributor

requirements_all.txt is not up to date
Please run script/gen_requirements_all.py

Please do not manual edit requirements_all.txt file, run script/gen_requirements_all.py instead

@davidlie
Copy link
Copy Markdown
Contributor Author

I get this error when i run script/gen_requirements_all.py:

******* ERROR
Errors while importing: homeassistant.components.climate.econet,
homeassistant.components.device_tracker.owntracks_http, homeassistant.components.google_assistant.auth, homeassistant.components.light.mqtt_json, homeassistant.components.light.mqtt_template, homeassistant.components.upnp.config_flow
Make sure you import 3rd party libraries inside methods.

I don't understand why I'm getting errors in this script for these components. I didn't touch them in this PR. Can you point me in the right direction?

@MartinHjelmare
Copy link
Copy Markdown
Member

Did you run script/setup first?

@davidlie
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare: Thanks for the advice. I'll read the documentation more carefully next time 😥. Properly generated requirements_all.txt commited now.

@fabaff fabaff merged commit 29984ef into home-assistant:dev Jan 28, 2019
@ghost ghost removed the in progress label Jan 28, 2019
@balloob balloob mentioned this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants