Merged
Conversation
homeassistant
added
integration: air_quality
small-pr
ghost
added
the
balloob
changed the title
balloob
approved these changes
Jan 22, 2019
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
Typo fix is good.
Adding a new attribute to an entity component requires an architecture issue.
Contributor
Author
|
Issue created: home-assistant/architecture#136 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
There was a typo in the air quality platform, ATTR_CO2 was spelled ATTR_C02, zero instead of big o.
This attribute wasn't used anywhere so no other files needed to be changed.
I took this opportunity to add VOC, Volatile Organic Compounds to the attributes list.
Considering many, if not most, indoor air quality devices derives their CO2 measurement from a VOC sensor.
Context: I'm migrating the foobot component from sensor to the air quality platform.
Checklist:
tox. Your PR cannot be merged unless tests pass