Minor webhook and http component improvements#20295
Merged
fabaff merged 1 commit intohome-assistant:devfrom Jan 21, 2019
andrewsayre:webhook_additions
Merged
Minor webhook and http component improvements#20295fabaff merged 1 commit intohome-assistant:devfrom andrewsayre:webhook_additions
fabaff merged 1 commit intohome-assistant:devfrom
andrewsayre:webhook_additions
Conversation
balloob
approved these changes
Jan 21, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
In the
webhookcomponent, adds the ability to generate a webhook path portion only (`async_generate_path'). This will be used by the SmartThings component (Add SmartThings component and switch platform #20148) so it does not need to hard-code the webhook path format (or alternatively, strip the base_url, url parse..., etc...).Also updates the
httpcomponent to ensure that thebase_urldoes not end up in a trailing slash. This could happen if the user accidentally enters a trialing slash onbase_urlin config which then results in generating webhook paths with an unnecessary slash after the host/port (i.e.http://localhost:8123//api/webhook/...)Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: