Update pyhomematic to 0.1.53#19056
Merged
balloob merged 1 commit intohome-assistant:devfrom Dec 6, 2018
danielperna84:homematic
Merged
Update pyhomematic to 0.1.53#19056balloob merged 1 commit intohome-assistant:devfrom danielperna84:homematic
balloob merged 1 commit intohome-assistant:devfrom
danielperna84:homematic
Conversation
2 tasks
balloob
reviewed
Dec 6, 2018
| DEFAULT_USERNAME = 'Admin' | ||
| DEFAULT_PASSWORD = '' | ||
| DEFAULT_SSL = False | ||
| DEFAULT_VERIFY_SSL = False |
Member
There was a problem hiding this comment.
We should default verify to True.
Contributor
Author
There was a problem hiding this comment.
Although I generally agree, for this case (and comparable ones) it wouldn't make sense to verify by default. The reason is, that the CCU-device never is a cloud device, it's always on premise. It can be exposed to the web, but that's a really bad idea. So typically nobody does that. And it's unrealistic, that people will use trusted certificates for a machine that's only local. They might have their custom CA. But last time I checked I couldn't make Home Assistant use a custom CA (virtualenv).
So essentially: having verify_ssl with True as default will be a broken-by-default configuration.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I have set
DEFAULT_VERIFY_SSLtoFalsebecause I am pretty sure, that at most an insignificant minority of users will have valid certificates configured on their CCU3.Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7750
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirements_all.txtby runningscript/gen_requirements_all.py.