Initial scene support for Fibaro hubs#18779

Merged

MartinHjelmare merged 9 commits intohome-assistant:devfrom

pbalogh77:scenes

Dec 3, 2018

Contributor

pbalogh77 commented Nov 29, 2018 •

edited

Loading

Added initial support for scenes to fibaro hub integration

Description:

Fibaro hub integration now imports and can activate scenes

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io
Fibaro scene doc added home-assistant.io#7715

If the code communicates with devices, web services, or third-party tools:

New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

pbalogh77 added 2 commits

November 29, 2018 13:42


          Initial scene support

febffa8

Added initial support for fibaro scenes


          removed comments

e7a89dd

homeassistant added cla-signed integration: fibaro new-platform platform: scene.fibaro labels

ghost added the in progress label

pbalogh77 changed the title ~~Initial scene support for Fibaro hubs~~ WIP: Initial scene support for Fibaro hubs


          Merge branch 'dev' of https://github.com/home-assistant/home-assistant …

687f594

…into scenes

pbalogh77 changed the title ~~WIP: Initial scene support for Fibaro hubs~~ Initial scene support for Fibaro hubs

balloob reviewed

View reviewed changes

homeassistant/components/scene/fibaro.py Show resolved Hide resolved

balloob reviewed

View reviewed changes

homeassistant/components/scene/fibaro.py Outdated Show resolved Hide resolved

Member

balloob commented Dec 2, 2018

Just a note that this is going to get a breaking change in the future as I want to break Home Assistant scenes out of the scene component and have a scene_external (with things like Fibaro) and scene which is scenes in Home Assistant land.

You're also welcome to open a PR to break up the component and then do a PR to add Fibaro to scene_external.


          cleanup based on code review

95a460b

houndci-bot reviewed

View reviewed changes

homeassistant/components/scene/fibaro.py Show resolved Hide resolved


          Removed unused functions

363984f

Contributor Author

pbalogh77 commented Dec 2, 2018

Just a note that this is going to get a breaking change in the future as I want to break Home Assistant scenes out of the scene component and have a scene_external (with things like Fibaro) and scene which is scenes in Home Assistant land.

You're also welcome to open a PR to break up the component and then do a PR to add Fibaro to scene_external.

I'm way too junior in this yet to do that :-) However, when it's done, I'll migrate my code to the new component.


          grrr, my mistake.

My local pylint and flake8 are playing tricks with me

houndci-bot reviewed

View reviewed changes

homeassistant/components/scene/fibaro.py Outdated Show resolved Hide resolved


          Update homeassistant/components/scene/fibaro.py

687ba10

MartinHjelmare reviewed

View reviewed changes

homeassistant/components/fibaro.py Outdated Show resolved Hide resolved

homeassistant/components/fibaro.py Outdated Show resolved Hide resolved

homeassistant/components/scene/fibaro.py Outdated Show resolved Hide resolved

homeassistant/components/scene/fibaro.py Show resolved Hide resolved


          fixes based on code review

041c3ff

ABC ordered the list of platforms
changed setup platform to async
removed overloaded name property as the FibaroDevice parent class already provides this
Changed to new style string formatting

MartinHjelmare reviewed

View reviewed changes

Member

MartinHjelmare left a comment

That should be enough.

homeassistant/components/scene/fibaro.py Outdated Show resolved Hide resolved


          Update homeassistant/components/scene/fibaro.py

2d2df08

Co-Authored-By: pbalogh77 <peter.balogh2@gmail.com>

MartinHjelmare approved these changes

View reviewed changes

Member

MartinHjelmare left a comment

Looks good!

Member

MartinHjelmare commented Dec 3, 2018

Can be merged when build passes and docs PR is linked above in this PR description.

Contributor Author

pbalogh77 commented Dec 3, 2018

Documentation added to home-assistant/home-assistant.io#7715

MartinHjelmare merged commit 149edda into home-assistant:dev

ghost removed the in progress label

balloob mentioned this pull request

Merged

ghost removed the platform: scene.fibaro label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed integration: fibaro new-platform