Skip to content

Clean up left-behind dispatcher handlers when removing RainMachine#18488

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
bachya:rainmachine-dispatcher
Nov 17, 2018
Merged

Clean up left-behind dispatcher handlers when removing RainMachine#18488
MartinHjelmare merged 2 commits intohome-assistant:devfrom
bachya:rainmachine-dispatcher

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Nov 15, 2018

Description:

The current implementation of RainMachine leaves behind some active dispatcher handlers when removing the component via the UI. This PR cleans that up (and centralizes that logic in the component, rather than across the platforms).

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

rainmachine:
  ip_address: !secret rainmachine_host
  password: !secret rainmachine_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@MartinHjelmare MartinHjelmare merged commit e73b9b9 into home-assistant:dev Nov 17, 2018
@ghost ghost removed the in progress label Nov 17, 2018
@bachya bachya deleted the rainmachine-dispatcher branch November 19, 2018 01:21
@balloob balloob mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants