Skip to content

Avg price for tibber sensor#18426

Merged
Danielhiversen merged 2 commits intodevfrom
tibber_avg_price
Nov 13, 2018
Merged

Avg price for tibber sensor#18426
Danielhiversen merged 2 commits intodevfrom
tibber_avg_price

Conversation

@Danielhiversen
Copy link
Copy Markdown
Member

Description:

Avg price for tibber sensor

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Comment thread homeassistant/components/sensor/tibber.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Danielhiversen Danielhiversen merged commit 7aa41d6 into dev Nov 13, 2018
@Danielhiversen Danielhiversen deleted the tibber_avg_price branch November 13, 2018 10:29
@ghost ghost removed the in progress label Nov 13, 2018
@balloob balloob mentioned this pull request Nov 29, 2018
@hulkhaugen
Copy link
Copy Markdown

Is it possible to round down to only 3 decimals without setting up a template sensor?

@Danielhiversen
Copy link
Copy Markdown
Member Author

I can add a round to the code.

@home-assistant home-assistant locked and limited conversation to collaborators Nov 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants