Skip to content

Return color information in Alexa Smart Home response#18368

Merged
balloob merged 1 commit intohome-assistant:devfrom
jackwilsdon:color_controller_properties
Nov 11, 2018
Merged

Return color information in Alexa Smart Home response#18368
balloob merged 1 commit intohome-assistant:devfrom
jackwilsdon:color_controller_properties

Conversation

@jackwilsdon
Copy link
Copy Markdown
Contributor

Description: Return color information in Alexa Smart Home response

This PR adds the color attribute for the Alexa.ColorController interface in the response, fixing an error that occurs within Alexa when setting the color of a device.

Related issue (if applicable): fixes #18367

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@jackwilsdon jackwilsdon force-pushed the color_controller_properties branch from 43471f8 to d1efb40 Compare November 11, 2018 01:20
@jackwilsdon jackwilsdon force-pushed the color_controller_properties branch from d1efb40 to ef79f16 Compare November 11, 2018 01:52
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@balloob balloob merged commit 5b9a9d8 into home-assistant:dev Nov 11, 2018
@ghost ghost removed the in progress label Nov 11, 2018
@jackwilsdon jackwilsdon deleted the color_controller_properties branch November 11, 2018 16:43
@balloob balloob mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"I'm not quite sure what went wrong." when setting the color of colored lights

4 participants