Add icon to Darksky summary sensors#18275
Merged
fabaff merged 1 commit intohome-assistant:devfrom Nov 7, 2018
leppa:darksky-summary-icons
Merged
Add icon to Darksky summary sensors#18275fabaff merged 1 commit intohome-assistant:devfrom leppa:darksky-summary-icons
fabaff merged 1 commit intohome-assistant:devfrom
leppa:darksky-summary-icons
Conversation
homeassistant
added
platform: sensor.darksky
small-pr
ghost
added
the
houndci-bot
reviewed
Nov 6, 2018
The icon changes dynamically, based on summary.
fabaff
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Some cards in HA show entity's icon instead of entity picture (e.g.
type: sensorin Lovelace UI). This change sets icon for summary sensors using the same logic as used for their entity picture.Checklist: