Merged
Conversation
homeassistant
added
platform: climate.mill
small-pr
ghost
assigned
balloob
reviewed
Nov 4, 2018
| """Return the state attributes.""" | ||
| if self._heater.room: | ||
| room = self._heater.room.name | ||
| avg_room_temp = self._heater.room.avg_temp |
Member
There was a problem hiding this comment.
shouldn't this be the value returned from current_temperature ?
Member
Author
There was a problem hiding this comment.
No, you can have several heaters in one room (Defined by Mill app). This will be the average temperature for all heaters in that room.
| "open_window": self._heater.open_window, | ||
| "heating": self._heater.is_heating, | ||
| "controlled_by_tibber": self._heater.tibber_control, | ||
| "avg_room_temp": avg_room_temp, |
Member
There was a problem hiding this comment.
We usually don't populate device state attributes with items where the value is None. Maybe we should check that here?
Member
Author
There was a problem hiding this comment.
Ok, so if it is None, we do not add it?
Member
There was a problem hiding this comment.
Yeah, that's an existing pattern.
MartinHjelmare
approved these changes
Nov 5, 2018
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Can be merged when build passes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Mill room temp
Checklist:
tox. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.