Fix temperature interval Thermostat HomeKit#18192
Merged
balloob merged 1 commit intohome-assistant:devfrom Nov 4, 2018
cdce8p:homekit-fix-temp-interval
Merged
Fix temperature interval Thermostat HomeKit#18192balloob merged 1 commit intohome-assistant:devfrom cdce8p:homekit-fix-temp-interval
balloob merged 1 commit intohome-assistant:devfrom
cdce8p:homekit-fix-temp-interval
Conversation
* Will round to nearest .0 or .5
ghost
assigned
balloob
approved these changes
Nov 4, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Although HomeKit and Home Assistant both round to the nearest
.0or.5value for climate temperatures, under some circumstances it could happen to be other values.1, ...This PR will make sure that the temperature values are updated correctly.
Related issue (if applicable): fixes #18187
Checklist:
tox. Your PR cannot be merged unless tests passReported by: @kamkilt