Support additional property for Homematic sabotage detection#17407
Merged
fabaff merged 1 commit intohome-assistant:devfrom Oct 13, 2018
Merged
Support additional property for Homematic sabotage detection#17407fabaff merged 1 commit intohome-assistant:devfrom
fabaff merged 1 commit intohome-assistant:devfrom
Conversation
At least HM-Sec-Sir-WM uses ERROR_SABOTAGE, see:
pyhomematic.devicetypes.actors.RFSiren
homeassistant
added
cla-signed
integration: homematic
small-pr
ghost
added
the
fabaff
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At least HM-Sec-Sir-WM uses
ERROR_SABOTAGE, seepyhomematic.devicetypes.actors.RFSiren.Description:
The Homematic siren uses a different attribute for sabotage reporting (
ERROR_SABOTAGE).pyhomematicalready handles this correctly, so let's also handle it in Home Assistant.Checklist:
tox. Your PR cannot be merged unless tests pass