Skip to content

Moved econet from climate to water heater#17322

Merged
fabaff merged 3 commits intohome-assistant:devfrom
w1ll1am23:move_econet_to_water_heater
Oct 13, 2018
Merged

Moved econet from climate to water heater#17322
fabaff merged 3 commits intohome-assistant:devfrom
w1ll1am23:move_econet_to_water_heater

Conversation

@w1ll1am23
Copy link
Copy Markdown
Contributor

@w1ll1am23 w1ll1am23 commented Oct 11, 2018

Description:

This PR moves econet water heaters to the new water_heater component added with #17058

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6676

Example entry for configuration.yaml (if applicable):

water_heater:
  - platform: econet
    username: test@test.com
    password: test1234

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Copy Markdown
Member

Please add a paragraph in the description that highlights the breaking change for the release notes.

@fabaff
Copy link
Copy Markdown
Member

fabaff commented Oct 13, 2018

Breaking change:

The econet climate platform was moved to the new water heater implementation. Please update your configuration, use water_heater now.

@fabaff fabaff merged commit 6a8eb8d into home-assistant:dev Oct 13, 2018
@ghost ghost removed the in progress label Oct 13, 2018
@w1ll1am23
Copy link
Copy Markdown
Contributor Author

@fabaff thanks I am on vacation so wouldn't be able to get to it for a few days.

@balloob balloob mentioned this pull request Oct 26, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants