Merged
Conversation
ghost
assigned
pvizeli
reviewed
Oct 4, 2018
Member
pvizeli
left a comment
pvizeli
left a comment
There was a problem hiding this comment.
Maybe it's look a bit easier if you use a schema they have extra=vol.REMOVE_EXTRA?
Member
Author
|
The issue is that passing in |
OttoWinter
reviewed
Oct 6, 2018
| 'sw_version', | ||
| 'via_hub', | ||
| ): | ||
| if key in device_info: |
Member
There was a problem hiding this comment.
Shouldn't this be if device_info.get(key) is not None:?
I think I've seen some device info implementations setting the values of keys to None to indicate absence. Or should that be changed per implementation?
Member
Author
There was a problem hiding this comment.
That should be changed in the implementation. If you set something to None, you indicate that it shouldn't be any value.
OttoWinter
added a commit
to OttoWinter/home-assistant
that referenced
this pull request
Oct 8, 2018
balloob
pushed a commit
that referenced
this pull request
Oct 8, 2018
* Implement base for MQTT device registry integration * Lint * Lint * Address comments * Lint * Lint * Address comments * Only add keys if specified See #17136 (comment)
balloob
added a commit
that referenced
this pull request
Oct 8, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Prevent data loss in the data registry. Data could get lost if a second entity pointing at the same device would contain less information.
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: