Homekit controller reconnect#17060
Merged
balloob merged 3 commits intohome-assistant:devfrom Oct 4, 2018
emlove:homekit-controller-reconnect
Merged
Homekit controller reconnect#17060balloob merged 3 commits intohome-assistant:devfrom emlove:homekit-controller-reconnect
balloob merged 3 commits intohome-assistant:devfrom
emlove:homekit-controller-reconnect
Conversation
ghost
assigned
houndci-bot
reviewed
Oct 2, 2018
| _LOGGER.info( | ||
| "Failed to connect to HomeKit device. Retrying in %d seconds.", | ||
| RETRY_INTERVAL, exc_info=ex) | ||
| call_later(self.hass, RETRY_INTERVAL, lambda _: self.accessory_setup()) |
Member
|
👍 on threaded call later. Didn't add it originally because no reason to add anything if it's not needed |
Member
|
CC @cdce8p |
pvizeli
reviewed
Oct 2, 2018
Member
pvizeli
left a comment
pvizeli
left a comment
There was a problem hiding this comment.
Yeah, I think that is in a way that is not going bad for devices and future calls. Also the logic is small.
Member
|
CC @mjg59 |
Member
|
Oops @cdce8p, wrong homekit component 😆 |
Contributor
|
Homekit commits look good to me |
balloob
approved these changes
Oct 4, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the homekit controller component so that it attempts to reconnect when the connection to a device is lost. This allows the component to recover after an intermittent network issue.
I've also added a threaded
call_laterhelper, since that variant seemed to be missing. I can split that commit to a separate PR if necessary, or I can remove it if I'm overlooking some reason we don't need this.