Use pysonos for Sonos media player#16753
Merged
balloob merged 1 commit intohome-assistant:devfrom Sep 20, 2018
Merged
Conversation
balloob
approved these changes
Sep 20, 2018
Member
balloob
left a comment
There was a problem hiding this comment.
I think this is fine, as long as we're staying ok with upstream.
Would be good to also notify them, as it might motivate them to improve their release cycle.
Do you envision still merging all your fixes upstream?
Contributor
Author
|
I did indeed plan to notify upstream if the change was accepted for Home Assistant. Now created an upstream issue mentioning the fork, SoCo/SoCo#638. Yes, I expect to submit future PRs to SoCo as well. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Our third party Sonos library, the SoCo project, does quarterly releases. This means that bugs can linger for 5-10 Home Assistant releases before an upstream fix is available from PyPI.
To overcome this frustrating situation, I have forked SoCo and intend to add patches for issues like #13984 and #16661.
This PR simply moves Home Assistant to use my fork, pysonos 0.0.1. It is identical to SoCo 0.16, assuming I have made no errors in renaming things.
Checklist:
tox.If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.