Fix camera proxy to not require api_password to function#16450
Merged
balloob merged 1 commit intohome-assistant:devfrom Sep 6, 2018
Merged
Fix camera proxy to not require api_password to function#16450balloob merged 1 commit intohome-assistant:devfrom
balloob merged 1 commit intohome-assistant:devfrom
Conversation
47a7a34 to
f1d3b79
Compare
f1d3b79 to
50f0d9a
Compare
Member
|
I know we've been jumping around in what the correct solution is here. Only recently did we make the image available for other components in this fashion. For streaming it is a lot more difficult as one needs to know how the stream is implemented to be able to iterate over it. So for now converting it to a stream ourselves is probably better, until we have time to fix camera plumbing once and for all (but I don't know how that would look) |
balloob
approved these changes
Sep 6, 2018
Member
|
Maybe like the image for cameras with generic token they change all 5min with url? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Enables camera.proxy to directly communicate with the proxied camera rather than using a URL. This enables the camera proxy to work without setting http.password_api
Related issue (if applicable): fixes #16402
Note that while this works fine, it does not directly consume the mjpeg stream from the proxied camera due to issues documented in #16402. Instead it relies on building the mjpeg from individual frames of the proxied camera.
This pull request is also related to #15376
Checklist:
tox. Your PR cannot be merged unless tests pass