Skip to content

Fix camera proxy to not require api_password to function#16450

Merged
balloob merged 1 commit intohome-assistant:devfrom
PhracturedBlue:camera_proxy_async
Sep 6, 2018
Merged

Fix camera proxy to not require api_password to function#16450
balloob merged 1 commit intohome-assistant:devfrom
PhracturedBlue:camera_proxy_async

Conversation

@PhracturedBlue
Copy link
Copy Markdown
Contributor

Description:

Enables camera.proxy to directly communicate with the proxied camera rather than using a URL. This enables the camera proxy to work without setting http.password_api

Related issue (if applicable): fixes #16402

Note that while this works fine, it does not directly consume the mjpeg stream from the proxied camera due to issues documented in #16402. Instead it relies on building the mjpeg from individual frames of the proxied camera.

This pull request is also related to #15376

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@balloob
Copy link
Copy Markdown
Member

balloob commented Sep 6, 2018

I know we've been jumping around in what the correct solution is here. Only recently did we make the image available for other components in this fashion. For streaming it is a lot more difficult as one needs to know how the stream is implemented to be able to iterate over it. So for now converting it to a stream ourselves is probably better, until we have time to fix camera plumbing once and for all (but I don't know how that would look)

@balloob balloob merged commit cf4b72e into home-assistant:dev Sep 6, 2018
@ghost ghost removed the in progress label Sep 6, 2018
@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Sep 6, 2018

Maybe like the image for cameras with generic token they change all 5min with url?

@balloob balloob mentioned this pull request Sep 17, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Camera proxy component is no longer working without api_password

4 participants