System Monitor Sensor shows IP4 address instead of MAC address#16394
Merged
fabaff merged 1 commit intohome-assistant:devfrom Sep 4, 2018
ReneNulschDE:Fix_Systemmonitor_IP-address
Merged
System Monitor Sensor shows IP4 address instead of MAC address#16394fabaff merged 1 commit intohome-assistant:devfrom ReneNulschDE:Fix_Systemmonitor_IP-address
fabaff merged 1 commit intohome-assistant:devfrom
ReneNulschDE:Fix_Systemmonitor_IP-address
Conversation
homeassistant
added
cla-signed
platform: sensor.systemmonitor
small-pr
fabaff
changed the title
fabaff
approved these changes
Sep 4, 2018
Member
fabaff
left a comment
fabaff
left a comment
There was a problem hiding this comment.
Thanks 🐦
Test case on a Linux system:
sensor:
- platform: systemmonitor
resources:
- type: ipv4_address
arg: enp0s
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
Merged
ghost
added
integration: systemmonitor
and removed
platform: sensor.systemmonitor
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
On Windows, the IP4-address is not the first item in the list of addresses. This PR adds an additional address.family checks to select the right item in the list independent from the sorting of the list.
Related issue (if applicable): fixes #16231
Checklist:
tox. Your PR cannot be merged unless tests pass