Skip to content

openalpr flag WITH_TEST should be WITH_TESTS#16218

Merged
fabaff merged 1 commit intohome-assistant:devfrom
vrih:correct-openalpr-build-flags
Aug 27, 2018
Merged

openalpr flag WITH_TEST should be WITH_TESTS#16218
fabaff merged 1 commit intohome-assistant:devfrom
vrih:correct-openalpr-build-flags

Conversation

@vrih
Copy link
Copy Markdown
Contributor

@vrih vrih commented Aug 27, 2018

Description:

Tiny commit that removes warning from openalpr build and saves a few seconds from build
time as tests weren't being bypassed as intended

Link to relevant flag in openalpr repo: https://github.com/openalpr/openalpr/blob/master/src/CMakeLists.txt#L42

Removes warning from openalpr build and saves a few seconds from build
time as tests weren't being bypassed as intended
@homeassistant homeassistant added cla-signed small-pr PRs with less than 30 lines. labels Aug 27, 2018
@ghost ghost added the in progress label Aug 27, 2018
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 8435d2f into home-assistant:dev Aug 27, 2018
@ghost ghost removed the in progress label Aug 27, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
Removes warning from openalpr build and saves a few seconds from build
time as tests weren't being bypassed as intended
@balloob balloob mentioned this pull request Sep 17, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants