Skip to content

Check correctly if package is loadable#16121

Merged
pvizeli merged 1 commit intodevfrom
package_loadable
Aug 22, 2018
Merged

Check correctly if package is loadable#16121
pvizeli merged 1 commit intodevfrom
package_loadable

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Aug 22, 2018

Description:

When checking if a dependency is installed for a component, don't just check if it's installed but also make sure that it's the one that will be loaded when we import it (ie it's the first in the dependency tree)

Related issue (if applicable): fixes #16120

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@pvizeli pvizeli merged commit 2e6cb22 into dev Aug 22, 2018
@pvizeli pvizeli deleted the package_loadable branch August 22, 2018 10:17
@ghost ghost removed the in progress label Aug 22, 2018
@balloob balloob mentioned this pull request Aug 29, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check_package_exists does not take load order into account

3 participants