Update reading when device is added#15548
Merged
balloob merged 1 commit intohome-assistant:devfrom Jul 18, 2018
quthla:patch-1
Merged
Update reading when device is added#15548balloob merged 1 commit intohome-assistant:devfrom quthla:patch-1
balloob merged 1 commit intohome-assistant:devfrom
quthla:patch-1
Conversation
homeassistant
added
cla-signed
platform: sensor.bme280
small-pr
ghost
added
the
balloob
reviewed
Jul 18, 2018
| pass | ||
|
|
||
| async_add_devices(dev) | ||
| async_add_devices(dev, True) |
Member
There was a problem hiding this comment.
Please remove the call to update from the BME280Handler constructor.
Contributor
Author
There was a problem hiding this comment.
I'm not sure if it's not needed to signal the underlying library the first reading.
Member
There was a problem hiding this comment.
update is our method. Adding True as second argument will make sure that Home Assistant calls update before adding to the state machine. So yes remove line 129.
Member
There was a problem hiding this comment.
Resolved in chat. Update in constructor is not for an entity
michaeldavie
pushed a commit
to michaeldavie/home-assistant
that referenced
this pull request
Jul 31, 2018
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Without this the first reading is received after scan_interval which is quite annoying in case scan interval is 300 seconds for example.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: