Skip to content

Add new types to Transmission sensors#14530

Merged
MartinHjelmare merged 1 commit intodevfrom
transmision-sensor
May 22, 2018
Merged

Add new types to Transmission sensors#14530
MartinHjelmare merged 1 commit intodevfrom
transmision-sensor

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented May 18, 2018

Description:

  • Add paused_torrents and total_torrents
  • Add data object
  • Remove GLOBAL
  • Add def available()
  • Introduce PlatformNotReady

Related issue (if applicable): fixes 53530 (partially)

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5393

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: transmission
    host: 127.0.0.1
    monitored_variables:
      - 'current_status'
      - 'download_speed'
      - 'upload_speed'
      - 'active_torrents'
      - 'paused_torrents'
      - 'total_torrents'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit a2f9fdf into dev May 22, 2018
@fabaff fabaff deleted the transmision-sensor branch May 22, 2018 16:04
@balloob balloob mentioned this pull request Jun 8, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants