renaming icons#13982
Merged
balloob merged 3 commits intohome-assistant:devfrom Apr 18, 2018
Merged
Conversation
homeassistant
added
cla-signed
integration: hdmi_cec
integration: vacuum
core
platform: vacuum.roomba
small-pr
syssi
reviewed
Apr 18, 2018
Member
syssi
left a comment
syssi
left a comment
There was a problem hiding this comment.
I would remove the icon overrides as far as the default icon is used.
Contributor
Author
|
So that would be all the vacuum components that have |
NovapaX
force-pushed
the
fix/rename-icons
branch
from
7a06caf to
f99707a
Compare
balloob
approved these changes
Apr 18, 2018
Merged
ghost
added
integration: dyson
integration: neato
integration: roomba
integration: xiaomi_miio
and removed
platform: vacuum.xiaomi_miio
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
this started with: home-assistant/frontend/issues/1003 and http://templarian.com/2018/04/18/material-design-icons-v2-3-50/
but added a default icon for vacuums in frontend so removed these from the backend: see home-assistant/frontend#1108
also changed the tuner icon to use a radio instead of a thermostat icon....