Small fix fix when dumping config when names are only digits but stil… #13377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l ok according to the validation (used with tellstick sensor mappings)
|
CLA signed! :) |
|
CC @kellerza |
kellerza
reviewed
Mar 23, 2018
| @@ -252,7 +252,7 @@ def dump_dict(layer, indent_count=3, listi=False, **kwargs): | |||
| """ | |||
| def sort_dict_key(val): | |||
| """Return the dict key for sorting.""" | |||
| key = str.lower(val[0]) | |||
| key = str.lower(val[0]) if isinstance(val[0], str) else str(val[0]) | |||
There was a problem hiding this comment.
Maybe just str(val[0]).lower() ?
There was a problem hiding this comment.
Yeah! That would be a nicer solution, but then it will always convert even if it is a string (witch it is in 99% of the cases). This is though just a function used with testing. So depends if nice code or speed is needed? ;)
There was a problem hiding this comment.
It's only for human consumption, like you say, so let go with nice code...
|
Thank you @hAmpzter ! 🎉 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l ok according to the validation (used with tellstick sensor mappings)
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: