updated to new "b2vapi" of BMW ConnectedDrive #13305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 18, 2018
| @@ -103,3 +111,21 @@ def update(self, *_): | |||
| def add_update_listener(self, listener): | |||
| """Add a listener for update notifications.""" | |||
| self._update_listeners.append(listener) | |||
|
|
|||
| def async_add_to_group(self, vehicle, entity_id: str): | |||
There was a problem hiding this comment.
I don't think we should create groups automatically. Let the users do that if they want.
There was a problem hiding this comment.
OK, removed the groups again.
I though it would be handy, as a vehicle might end up with 10-15 individual sensors. And creating the groups manually is annoying...
ChristianKuehnel
force-pushed
the
b2vapi
branch
from
4e98184
to
3872022
Compare
4 tasks
ChristianKuehnel
requested review from
amelchio,
cdce8p,
Danielhiversen and
a team
as code owners
ChristianKuehnel
force-pushed
the
b2vapi
branch
from
16abde6
to
08150ec
Compare
ChristianKuehnel
changed the title
|
Implementation and tests completed, ready to be reviewed and merged. |
MartinHjelmare
requested changes
Mar 24, 2018
| @@ -6,7 +6,6 @@ | |||
| """ | |||
| import logging | |||
| import datetime | |||
|
|
|||
There was a problem hiding this comment.
Please keep the blank line between standard library and 3rd party imports.
| @@ -6,7 +6,6 @@ | |||
| """ | |||
| import logging | |||
| import datetime | |||
There was a problem hiding this comment.
Please sort 🔤 within groups standard library, 3rd party and homeassistant imports.
MartinHjelmare
added
breaking-change
and removed
core
integration: device_tracker
labels
ChristianKuehnel
force-pushed
the
b2vapi
branch
from
57ed1bb
to
0719380
Compare
MartinHjelmare
requested changes
Mar 24, 2018
| import datetime | ||
|
|
||
| import logging | ||
| import voluptuous as vol |
There was a problem hiding this comment.
There should be a blank line here between logging and voluptuous.
Merged
ghost
removed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
To support users from USA and Canada, the bimmer_connected library moved to a different API on the BMW servers. As this is a breaking changes for the bimmer_connected library, several changes were required to the Home Assistant modules.
The
countryattribute in the configuration is now replaced with aregionattribute.Related issue (if applicable): fixes N/A
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4947
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: