Add effects to iGlo Lights#12365
Merged
balloob merged 2 commits intohome-assistant:devfrom Feb 16, 2018
Merged
Conversation
Simplify state variables to library
homeassistant
added
cla-signed
platform: light.iglo
small-pr
houndci-bot
reviewed
Feb 13, 2018
| """Flag supported features.""" | ||
| return SUPPORT_BRIGHTNESS | SUPPORT_COLOR_TEMP | SUPPORT_RGB_COLOR | ||
| return (SUPPORT_BRIGHTNESS | SUPPORT_COLOR_TEMP | | ||
| SUPPORT_RGB_COLOR | SUPPORT_EFFECT) |
There was a problem hiding this comment.
continuation line under-indented for visual indent
| def color_temp(self): | ||
| """Return the color temperature.""" | ||
| return color_util.color_temperature_kelvin_to_mired(self._color_temp) | ||
| return color_util.color_temperature_kelvin_to_mired(self._lamp.state['white']) |
There was a problem hiding this comment.
line too long (86 > 79 characters)
balloob
approved these changes
Feb 16, 2018
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add effects to iGlo lights and also always fetch state variables from library (local object only)
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.