Skip to content

Respond to Alexa scene activation correctly#11869

Merged
balloob merged 1 commit into
home-assistant:devfrom
bitglue:scene
Jan 23, 2018
Merged

Respond to Alexa scene activation correctly#11869
balloob merged 1 commit into
home-assistant:devfrom
bitglue:scene

Conversation

@bitglue
Copy link
Copy Markdown
Member

@bitglue bitglue commented Jan 23, 2018

Description:

The API documentation specifies that Alexa.SceneController Activate
must get a ActivationStarted response. Responding with just a Response
will elicit a "Hmm... $scene is not responding" from Alexa.

Checklist:

  • The code change is tested and works locally.
  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

The API documentation[1] specifies that Alexa.SceneController Activate
must get a ActivationStarted response. Responding with just a `Response`
will elicit a "Hmm... $scene is not responding" from Alexa.

[1]: https://developer.amazon.com/docs/smarthome/provide-scenes-in-a-smart-home-skill.html
@philk
Copy link
Copy Markdown
Contributor

philk commented Jan 23, 2018

YES, thank you! I spent an hour or so last weekend poking around to see if I could figure out why this was broken and had no luck (guess it helps to read the docs more thoroughly...😅). Cherry-picked this change and it's working great.

@balloob balloob merged commit 95592d9 into home-assistant:dev Jan 23, 2018
@bitglue
Copy link
Copy Markdown
Member Author

bitglue commented Jan 23, 2018

@philk I've found https://github.com/alexa/alexa-smarthome/tree/master/sample_messages to be the most helpful resource for such things.

@balloob balloob mentioned this pull request Jan 26, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants