Expose Alexa Smart Home via HTTP POST#11859
Conversation
There was a problem hiding this comment.
line too long (80 > 79 characters)
Haaska was using the v2 payload, which is now deprecated. Fortunately, home-assistant implemented the v3 payload. home-assistant/core#11859 exposes this via an HTTP POST, which allows Haaska's Lambda function to be simplified to some trivial glue.
There was a problem hiding this comment.
Instead of vol.Any, just mark the key as vol.Optional (like this)
There was a problem hiding this comment.
You probably have to wrap the containing dictionary in a vol.Schema: DOMAIN: vol.Schema({
There was a problem hiding this comment.
Oh I guess you still need to use Any with None since the presence of the key indicates setting up the smart home view.
Nevermind this comment.
|
Awesome! 👍 I was expecting this PR 😉 |
|
One more thing, please add a quick test to make sure the http frontend works |
Haaska uses the deprecated v2 Alexa Smart Home payload. Exposing the v3 implementation this way allows an easy path to upgrading Haaska and reducing code duplication with Home Assistant Cloud.
|
@balloob Done. Changes were simple enough I just squashed them. Hope that's OK. |
Haaska uses the deprecated v2 Alexa Smart Home payload. Exposing the v3 implementation this way allows an easy path to upgrading Haaska and reducing code duplication with Home Assistant Cloud.
|
Not sure what's up with Travis. Seems unrelated to my changes? |
|
Travis choked on a flaky test. That's fine. Great work! |
|
@bitglue: Thank you very much for this PR! May I ask you to add Alexa.TemperatureSensor and Alexa.ThermostatController features? |
|
Please use our forum for feature requests. This PR is merged. |
6 participants
Description:
Haaska uses the deprecated v2 Alexa Smart Home payload. Exposing the v3
implementation this way allows an easy path to upgrading Haaska and
reducing code duplication with Home Assistant Cloud.
Related issue: auchter/haaska#102
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4493
Example entry for
configuration.yaml(if applicable):See documentation PR: home-assistant/home-assistant.io#4493
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass