Fix purge with MariaDB / MySQL#11713
Merged
Merged
Conversation
Closed
balloob
approved these changes
Jan 16, 2018
Member
|
Ran tests locally, all good 👍 |
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Since #11039 (i.e., since 0.61), the recorder does not work for users of MariaDB / MySQL, because they behave strangely regarding subqueries (see also this thread: [0]).
This PR fixes this by completely removing subqueries. Instead, the IDs of protected states / events are passed via the SQL query. This might slow down purges a bit for systems which have seen a lot of different entity IDs.
I don't intend for this to be a permanent solution. I'll try to come up with something more efficient that also works with MariaDB and MySQL, but that will require more testing, and I'd like to fix this as quickly as possible.
[0] https://groups.google.com/forum/#!topic/sqlalchemy/T-X9gxuoqA8
Related issue (if applicable): fixes #11559
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass