History order bugfix and opt-in option#11686
Merged
Merged
Conversation
houndci-bot
reviewed
Jan 16, 2018
| break | ||
| sorted_result.extend(result) | ||
| result = sorted_result | ||
|
|
|
|
||
| hass.http.register_view(HistoryPeriodView(filters)) | ||
| use_include_order = config[DOMAIN].get(CONF_ORDER) | ||
|
|
2 tasks
Contributor
|
Just tried it in |
balloob
approved these changes
Jan 16, 2018
balloob
pushed a commit
that referenced
this pull request
Jan 16, 2018
* make history view re-ordering optional and opt-in, also fix type bug * use python false for default value * whitespace cleanup
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This fix does two things:
Related issue (if applicable): fixes #11671
If someone wants to use the new history ordering feature, they would add the configuration parameter as shown below:
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass