Skip to content

Add valve platform to google_assistant#30435

Merged
jbouwh merged 1 commit into
nextfrom
jbouwh-google_assistant-valve
Dec 23, 2023
Merged

Add valve platform to google_assistant#30435
jbouwh merged 1 commit into
nextfrom
jbouwh-google_assistant-valve

Conversation

@jbouwh
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh commented Dec 20, 2023

Proposed change

Add valve platform support to google_assistant

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Dec 20, 2023
@jbouwh jbouwh force-pushed the jbouwh-google_assistant-valve branch from f17dabd to 68bc314 Compare December 21, 2023 09:01
Copy link
Copy Markdown
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jbouwh 👍

@jbouwh jbouwh added awaits-parent Awaits the merge of an parent PR integration: google_assistant labels Dec 21, 2023
@home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/cloud, mind taking a look at this feedback as it has been labeled with an integration (google_assistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of google_assistant can trigger bot actions by commenting:

  • @home-assistant close Closes the feedback.
  • @home-assistant rename Awesome new title Renames the feedback.
  • @home-assistant reopen Reopen the feedback.
  • @home-assistant unassign google_assistant Removes the current integration label and assignees on the feedback, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information) to the feedback.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information) on the feedback.

@jbouwh jbouwh merged commit d4e205a into next Dec 23, 2023
@jbouwh jbouwh deleted the jbouwh-google_assistant-valve branch December 23, 2023 15:46
@home-assistant home-assistant Bot removed the awaits-parent Awaits the merge of an parent PR label Dec 23, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo integration: google_assistant next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants