light-blinkt: add documentation for new light#2535
Conversation
Landrash
added
the
new-integration
Landrash
left a comment
Landrash
left a comment
There was a problem hiding this comment.
Some minor tweaks but looks good in general.
| --- | ||
| layout: page | ||
| title: "Blinkt!" | ||
| description: "Instructions how to setup Sense HAT LED lights within Home Assistant." |
There was a problem hiding this comment.
Description differs from rest of the document.
There was a problem hiding this comment.
Sorry, that's very careless of me, fixing.
| @@ -0,0 +1,23 @@ | |||
| --- | |||
| layout: page | |||
| title: "Blinkt!" | |||
There was a problem hiding this comment.
Remove the ! from the title.
There was a problem hiding this comment.
@Landrash The component's original name actually includes the ! (see https://shop.pimoroni.com/products/blinkt), of course I'm happy to remove it, just wondering if there's a specific reason to do so? (does it mess with these docs some way?)
There was a problem hiding this comment.
Oh if that's the name standardized the other way around and try to use Blinkt! everywhere possible. 😊
There was a problem hiding this comment.
I just realized that's what you did. Good work.
Landrash
left a comment
Landrash
left a comment
There was a problem hiding this comment.
Looks good and can be merged when parent pr is merged.
|
Cherry-picked for 0.44 |
3 participants
Description:
Add documentation for new light, using Blinkt!.
Pull request in home-assistant (if applicable): home-assistant/core#7377