Added documentation for Ring binary sensor#2231
Merged
Merged
Conversation
8 tasks
Landrash
approved these changes
Mar 11, 2017
Contributor
Landrash
left a comment
Landrash
left a comment
There was a problem hiding this comment.
This can be merged if the parent pr isn't changed.
Some minor question about the config variables.
|
|
||
| - **username** (*Required*): The username for accessing your Ring account. | ||
| - **password** (*Required*): The password for accessing your Ring account. | ||
| - **monitored_conditions** array (*Required*): Conditions to display in the frontend. The following conditions can be monitored. |
Contributor
There was a problem hiding this comment.
Are both of these required? If not I think It should be marked as optional and to be removed from the minimal example.
If they generally are always monitored I don't see a reason to have them included by default by the component and remove the configuration variable.
Contributor
Author
There was a problem hiding this comment.
Hello @Landrash,
By default there are not included or monitored. The user must specify which sensor to use.
The user can choose only one or 2 sensors. They are not dependent.
Landrash
added
the
new-integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added documentation for Ring binary sensors
Pull request in home-assistant (if applicable): home-assistant/core#6520
https://community-home-assistant-assets.s3.amazonaws.com/original/2X/f/f32ab302af330212fd4e6b69194a9e6961cd7131.png
Configuration