From a1b438948896e4554c5ea6c4d984c2d0d0b34cd9 Mon Sep 17 00:00:00 2001 From: Tsvi Mostovicz Date: Fri, 27 Sep 2019 00:47:57 +0300 Subject: [PATCH 1/4] Add documentation about new key: time_format Based on PR home-assistant/home-asssitant#26940 this adds athe documentation about the new key + a warning on relying to much on the time based sensors. --- source/_integrations/jewish_calendar.markdown | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/source/_integrations/jewish_calendar.markdown b/source/_integrations/jewish_calendar.markdown index 3166f74adf8c..c4fe56f52412 100644 --- a/source/_integrations/jewish_calendar.markdown +++ b/source/_integrations/jewish_calendar.markdown @@ -49,6 +49,11 @@ havdalah_minutes_after_sunset: description: Number of minutes after sunset to report as havdalah time. If this is set to 0, uses the time that the sun is 8.5 degrees below the horizon (same as the 'three_stars' sensor). If non-zero, this value is added as an offset to the time of sunset to report havdalah. default: 0 type: integer +time_format: + required: false + description: Time format for output of time sensors + default: "%H:%M" + type: string {% endconfiguration %} ## Sensor list @@ -61,6 +66,10 @@ havdalah_minutes_after_sunset: - omer_count: An integer sensor indicating the day of the Omer (1-49) or 0 if it is not currently the Omer. ### Time sensors + +*Note: Due to the variety of rabbinic opinions on how to calculate the different times, we do not take any responsibility on your religious reliance upon the calculations.* + +By default the time sensors are represented as hour:minute. By changing the `time_format` value you can have the sensor display the timestamp in any format you want as described [here](http://strftime.org/). - first_light: First light of dawn (Alot Hashachar - עלות השחר). - gra_end_shma: Last time for reading of the Shma according to the GR"A. - mga_end_shma: Last time for reading of the Shma according to the MG"A. @@ -95,4 +104,5 @@ jewish_calendar: language: english diaspora: true havdalah_minutes_after_sunset: 50 + time_format: "%c" ``` From 07555fb121fa275c9719f2081f322efdebb925d6 Mon Sep 17 00:00:00 2001 From: Tsvi Mostovicz Date: Sun, 6 Oct 2019 15:47:17 +0300 Subject: [PATCH 2/4] Remove time_format key as it doesn't belong in backend --- source/_integrations/jewish_calendar.markdown | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/source/_integrations/jewish_calendar.markdown b/source/_integrations/jewish_calendar.markdown index c4fe56f52412..8e2ac58af3cb 100644 --- a/source/_integrations/jewish_calendar.markdown +++ b/source/_integrations/jewish_calendar.markdown @@ -49,11 +49,6 @@ havdalah_minutes_after_sunset: description: Number of minutes after sunset to report as havdalah time. If this is set to 0, uses the time that the sun is 8.5 degrees below the horizon (same as the 'three_stars' sensor). If non-zero, this value is added as an offset to the time of sunset to report havdalah. default: 0 type: integer -time_format: - required: false - description: Time format for output of time sensors - default: "%H:%M" - type: string {% endconfiguration %} ## Sensor list @@ -69,7 +64,7 @@ time_format: *Note: Due to the variety of rabbinic opinions on how to calculate the different times, we do not take any responsibility on your religious reliance upon the calculations.* -By default the time sensors are represented as hour:minute. By changing the `time_format` value you can have the sensor display the timestamp in any format you want as described [here](http://strftime.org/). +Time sensors are represented in ISO8601 format. For easier use in automations, all time sensors have a `timestamp` attribute, which returns the UNIX timestamp. - first_light: First light of dawn (Alot Hashachar - עלות השחר). - gra_end_shma: Last time for reading of the Shma according to the GR"A. - mga_end_shma: Last time for reading of the Shma according to the MG"A. From 0112002721bd17893f1ead7b701ffd48850705d6 Mon Sep 17 00:00:00 2001 From: Tsvi Mostovicz Date: Sun, 6 Oct 2019 15:47:51 +0300 Subject: [PATCH 3/4] Remove time_format from the full configuration example --- source/_integrations/jewish_calendar.markdown | 1 - 1 file changed, 1 deletion(-) diff --git a/source/_integrations/jewish_calendar.markdown b/source/_integrations/jewish_calendar.markdown index 8e2ac58af3cb..f685f6b198e5 100644 --- a/source/_integrations/jewish_calendar.markdown +++ b/source/_integrations/jewish_calendar.markdown @@ -99,5 +99,4 @@ jewish_calendar: language: english diaspora: true havdalah_minutes_after_sunset: 50 - time_format: "%c" ``` From cd410383d8bdf3711db2490c2768adfa17a3f2ac Mon Sep 17 00:00:00 2001 From: Tsvi Mostovicz Date: Thu, 10 Oct 2019 19:32:09 +0300 Subject: [PATCH 4/4] Add info about time being represented as UTC --- source/_integrations/jewish_calendar.markdown | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/source/_integrations/jewish_calendar.markdown b/source/_integrations/jewish_calendar.markdown index f685f6b198e5..9c6034bf43e7 100644 --- a/source/_integrations/jewish_calendar.markdown +++ b/source/_integrations/jewish_calendar.markdown @@ -62,9 +62,11 @@ havdalah_minutes_after_sunset: ### Time sensors -*Note: Due to the variety of rabbinic opinions on how to calculate the different times, we do not take any responsibility on your religious reliance upon the calculations.* +*Note: Due to the variety of rabbinic opinions on how to calculate the different times, we do not take any responsibility on your religious reliance upon these calculations.* + +Time sensor states are represented as ISO8601 formatted *UTC time*. +For easier use in automations, all time sensors have a `timestamp` attribute, which returns the UNIX timestamp. -Time sensors are represented in ISO8601 format. For easier use in automations, all time sensors have a `timestamp` attribute, which returns the UNIX timestamp. - first_light: First light of dawn (Alot Hashachar - עלות השחר). - gra_end_shma: Last time for reading of the Shma according to the GR"A. - mga_end_shma: Last time for reading of the Shma according to the MG"A.