Skip to content

Adds folder sensor#4588

Merged
fabaff merged 9 commits intohome-assistant:nextfrom
robmarkcole:folder
Feb 23, 2018
Merged

Adds folder sensor#4588
fabaff merged 9 commits intohome-assistant:nextfrom
robmarkcole:folder

Conversation

@robmarkcole
Copy link
Copy Markdown
Contributor

@robmarkcole robmarkcole commented Feb 6, 2018

Description:
Home-assistant component for monitoring the contents of a folder.
The state of the sensor is the time that the most recently modified file in a folder was modified. The use case is detecting when a file in a folder is created or updated. The number of files in the folder and the names of those files are exposed as attributes. Optionally a filter can be applied to the files considered.

Pull request in home-assistant (if applicable): home-assistant/core#12208

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • [x ] The documentation follow the standards.

frenck
frenck previously requested changes Feb 8, 2018
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robmarkcole Could you please take a look at my comments?

folder: /config
```

Configuration variables:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the configuration tags, for more information please see:
https://home-assistant.io/developers/documentation/create_page/#configuration

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove the header "Configuration variables:" as well 😉

ha_release: 0.63
---

Home-assistant component for monitoring the contents of a folder.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Home-assistant -> Home Assistant.

In general, I'd suggest rewriting this sentence since it is kinda obvious that this component is for Home Assistant already 😉

@frenck frenck added the new-integration This PR adds documentation for a new Home Assistant integration label Feb 8, 2018
fabaff
fabaff previously approved these changes Feb 23, 2018
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff dismissed frenck’s stale review February 23, 2018 18:19

Comments addressed

@fabaff fabaff merged commit 72f1cdc into home-assistant:next Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-integration This PR adds documentation for a new Home Assistant integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants