Skip to content

Add documentation for the verify configuration variable of component …#3282

Merged
frenck merged 2 commits into
home-assistant:nextfrom
ohmer1:xmpp_no_cert_verify
Sep 6, 2017
Merged

Add documentation for the verify configuration variable of component …#3282
frenck merged 2 commits into
home-assistant:nextfrom
ohmer1:xmpp_no_cert_verify

Conversation

@ohmer1
Copy link
Copy Markdown
Contributor

@ohmer1 ohmer1 commented Aug 31, 2017

…otify.xmpp (#9181).

Add documentation for the verify configuration variable of component notify.xmpp

Pull request in home-assistant (if applicable): home-assistant/core#9181

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Minor grammar issue's found.
@ohmer1, could you please take a look?

Comment thread source/_components/notify.xmpp.markdown Outdated
- **password** (*Required*): The password for your given Jabber account.
- **recipient** (*Required*): The Jabber ID (JID) that will receive the messages.
- **tls** (*Optional*): Allow to disable TLS. Defaults to `true`.
- **verify** (*Optional*): Allow to disable SSL certificate validity check (eg. self-signed certificate). Defaults to `true`.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling & Grammar:
Allow to disable SSL certificate validity check (eg. self-signed certificate). -> Allow disabling SSL certificate validity check (e.g., self-signed certificate).

@frenck
Copy link
Copy Markdown
Member

frenck commented Sep 2, 2017

Thanks for fixing those minors @ohmer1! 🥇

@frenck frenck merged commit f912be9 into home-assistant:next Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants