Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate all icon button logic into <ha-icon-button> + ensure tooltip #9230

Merged
merged 33 commits into from
Oct 14, 2021

Conversation

spacegaier
Copy link
Member

@spacegaier spacegaier commented May 22, 2021

Breaking change

Proposed change

Icon buttons should by default have a tooltip plus an ARIA label. This PR consolidates all icon button logic (regular and SVG) into <ha-icon-button> for a consistent behavior.

  • Check aria-label handling
  • Check existing <ha-icon-button> for correct syntax
  • Go trough all <ha-svg-icon> 😬
  • Cleanup imports
  • Replace "hass:" icons

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes
  • This PR is related to issue or discussion: Unlabeled buttons #3267
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@spacegaier spacegaier mentioned this pull request Jun 15, 2021
@spacegaier spacegaier changed the title Consolidate all icon logic into <ha-icon-button + ensure tooltip Consolidate all icon logic into <ha-icon-button> + ensure tooltip Jun 15, 2021
@spacegaier spacegaier changed the title Consolidate all icon logic into <ha-icon-button> + ensure tooltip Consolidate all icon button logic into <ha-icon-button> + ensure tooltip Jun 15, 2021
@bramkragten
Copy link
Member

When you are going through all current ha-icon-button, can you also convert all the static hass: icons to svg paths?

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 4, 2021
@spacegaier spacegaier removed the stale label Oct 4, 2021
@spacegaier spacegaier marked this pull request as ready for review October 4, 2021 20:14
@spacegaier
Copy link
Member Author

When you are going through all current ha-icon-button, can you also convert all the static hass: icons to svg paths?

Done for the *.ts files. The old *.js should be converted once they migrate to TS.

@bramkragten bramkragten merged commit 0c940be into home-assistant:dev Oct 14, 2021
@spacegaier spacegaier deleted the ha-icon-button branch October 14, 2021 14:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants