From cb6d264b1dee8179c00bdc5efaecc9aa2a952e5b Mon Sep 17 00:00:00 2001 From: Philip Allgaier Date: Tue, 3 Nov 2020 13:01:20 +0100 Subject: [PATCH 1/4] Ensure all set a label for ARIA --- src/panels/config/areas/ha-config-areas-dashboard.ts | 3 +++ src/panels/config/automation/ha-automation-editor.ts | 1 + src/panels/config/automation/ha-automation-picker.ts | 3 +++ src/panels/config/helpers/ha-config-helpers.ts | 3 +++ src/panels/config/integrations/ha-config-integrations.ts | 2 +- .../integration-panels/zha/zha-config-dashboard.ts | 1 + .../integration-panels/zha/zha-groups-dashboard.ts | 1 + .../lovelace/dashboards/ha-config-lovelace-dashboards.ts | 3 +++ .../config/lovelace/resources/ha-config-lovelace-resources.ts | 3 +++ src/panels/config/person/ha-config-person.ts | 1 + src/panels/config/scene/ha-scene-dashboard.ts | 3 +++ src/panels/config/scene/ha-scene-editor.ts | 1 + src/panels/config/script/ha-script-editor.ts | 3 +++ src/panels/config/script/ha-script-picker.ts | 3 +++ src/panels/config/tags/ha-config-tags.ts | 1 + src/panels/config/users/ha-config-users.ts | 1 + src/panels/config/zone/ha-config-zone.ts | 1 + src/panels/lovelace/views/hui-masonry-view.ts | 3 +++ src/panels/lovelace/views/hui-panel-view.ts | 3 +++ 19 files changed, 39 insertions(+), 1 deletion(-) diff --git a/src/panels/config/areas/ha-config-areas-dashboard.ts b/src/panels/config/areas/ha-config-areas-dashboard.ts index 4b39809d33e5..2c7aba5341e1 100644 --- a/src/panels/config/areas/ha-config-areas-dashboard.ts +++ b/src/panels/config/areas/ha-config-areas-dashboard.ts @@ -129,6 +129,9 @@ export class HaConfigAreasDashboard extends LitElement { title="${this.hass.localize( "ui.panel.config.areas.picker.create_area" )}" + label="${this.hass.localize( + "ui.panel.config.areas.picker.create_area" + )}" @click=${this._createArea} > diff --git a/src/panels/config/automation/ha-automation-editor.ts b/src/panels/config/automation/ha-automation-editor.ts index 9552fd5d9f5a..1d6dbccd9ad8 100644 --- a/src/panels/config/automation/ha-automation-editor.ts +++ b/src/panels/config/automation/ha-automation-editor.ts @@ -473,6 +473,7 @@ export class HaAutomationEditor extends KeyboardShortcutMixin(LitElement) { slot="fab" class=${classMap({ dirty: this._dirty })} .title=${this.hass.localize("ui.panel.config.automation.editor.save")} + label=${this.hass.localize("ui.panel.config.automation.editor.save")} @click=${this._saveAutomation} > diff --git a/src/panels/config/automation/ha-automation-picker.ts b/src/panels/config/automation/ha-automation-picker.ts index 02cdf95a45d4..c26160a9c382 100644 --- a/src/panels/config/automation/ha-automation-picker.ts +++ b/src/panels/config/automation/ha-automation-picker.ts @@ -179,6 +179,9 @@ class HaAutomationPicker extends LitElement { title=${this.hass.localize( "ui.panel.config.automation.picker.add_automation" )} + label=${this.hass.localize( + "ui.panel.config.automation.picker.add_automation" + )} @click=${this._createNew} > diff --git a/src/panels/config/helpers/ha-config-helpers.ts b/src/panels/config/helpers/ha-config-helpers.ts index 81794746393c..b97b83f5d266 100644 --- a/src/panels/config/helpers/ha-config-helpers.ts +++ b/src/panels/config/helpers/ha-config-helpers.ts @@ -163,6 +163,9 @@ export class HaConfigHelpers extends LitElement { title="${this.hass.localize( "ui.panel.config.helpers.picker.add_helper" )}" + label="${this.hass.localize( + "ui.panel.config.helpers.picker.add_helper" + )}" @click=${this._createHelpler} > diff --git a/src/panels/config/integrations/ha-config-integrations.ts b/src/panels/config/integrations/ha-config-integrations.ts index 915cd4920e65..615e075f05d4 100644 --- a/src/panels/config/integrations/ha-config-integrations.ts +++ b/src/panels/config/integrations/ha-config-integrations.ts @@ -475,7 +475,7 @@ class HaConfigIntegrations extends SubscribeMixin(LitElement) { diff --git a/src/panels/config/integrations/integration-panels/zha/zha-config-dashboard.ts b/src/panels/config/integrations/integration-panels/zha/zha-config-dashboard.ts index 32db5e38d7ec..bb854a7ad790 100644 --- a/src/panels/config/integrations/integration-panels/zha/zha-config-dashboard.ts +++ b/src/panels/config/integrations/integration-panels/zha/zha-config-dashboard.ts @@ -85,6 +85,7 @@ class ZHAConfigDashboard extends LitElement { diff --git a/src/panels/config/integrations/integration-panels/zha/zha-groups-dashboard.ts b/src/panels/config/integrations/integration-panels/zha/zha-groups-dashboard.ts index ba4342b1fd4f..0b413954aa02 100644 --- a/src/panels/config/integrations/integration-panels/zha/zha-groups-dashboard.ts +++ b/src/panels/config/integrations/integration-panels/zha/zha-groups-dashboard.ts @@ -129,6 +129,7 @@ export class ZHAGroupsDashboard extends LitElement { diff --git a/src/panels/config/lovelace/dashboards/ha-config-lovelace-dashboards.ts b/src/panels/config/lovelace/dashboards/ha-config-lovelace-dashboards.ts index 22552227814c..a18b88b537d3 100644 --- a/src/panels/config/lovelace/dashboards/ha-config-lovelace-dashboards.ts +++ b/src/panels/config/lovelace/dashboards/ha-config-lovelace-dashboards.ts @@ -228,6 +228,9 @@ export class HaConfigLovelaceDashboards extends LitElement { title="${this.hass.localize( "ui.panel.config.lovelace.dashboards.picker.add_dashboard" )}" + label="${this.hass.localize( + "ui.panel.config.lovelace.dashboards.picker.add_dashboard" + )}" @click=${this._addDashboard} > diff --git a/src/panels/config/lovelace/resources/ha-config-lovelace-resources.ts b/src/panels/config/lovelace/resources/ha-config-lovelace-resources.ts index 5ae5003d5acd..9c82699dfc2d 100644 --- a/src/panels/config/lovelace/resources/ha-config-lovelace-resources.ts +++ b/src/panels/config/lovelace/resources/ha-config-lovelace-resources.ts @@ -108,6 +108,9 @@ export class HaConfigLovelaceRescources extends LitElement { title=${this.hass.localize( "ui.panel.config.lovelace.resources.picker.add_resource" )} + label=${this.hass.localize( + "ui.panel.config.lovelace.resources.picker.add_resource" + )} @click=${this._addResource} > diff --git a/src/panels/config/person/ha-config-person.ts b/src/panels/config/person/ha-config-person.ts index d7403b341a9c..d23d1af5c7dc 100644 --- a/src/panels/config/person/ha-config-person.ts +++ b/src/panels/config/person/ha-config-person.ts @@ -149,6 +149,7 @@ class HaConfigPerson extends LitElement { diff --git a/src/panels/config/scene/ha-scene-dashboard.ts b/src/panels/config/scene/ha-scene-dashboard.ts index 18666ee10c0d..27a06b7a10de 100644 --- a/src/panels/config/scene/ha-scene-dashboard.ts +++ b/src/panels/config/scene/ha-scene-dashboard.ts @@ -156,6 +156,9 @@ class HaSceneDashboard extends LitElement { title=${this.hass.localize( "ui.panel.config.scene.picker.add_scene" )} + label=${this.hass.localize( + "ui.panel.config.scene.picker.add_scene" + )} > diff --git a/src/panels/config/scene/ha-scene-editor.ts b/src/panels/config/scene/ha-scene-editor.ts index 22bbba718d99..22336ef9c95b 100644 --- a/src/panels/config/scene/ha-scene-editor.ts +++ b/src/panels/config/scene/ha-scene-editor.ts @@ -406,6 +406,7 @@ export class HaSceneEditor extends SubscribeMixin( diff --git a/src/panels/config/script/ha-script-editor.ts b/src/panels/config/script/ha-script-editor.ts index 63dc5bfcb3ab..efaf022a2fbc 100644 --- a/src/panels/config/script/ha-script-editor.ts +++ b/src/panels/config/script/ha-script-editor.ts @@ -370,6 +370,9 @@ export class HaScriptEditor extends KeyboardShortcutMixin(LitElement) { .title=${this.hass.localize( "ui.panel.config.script.editor.save_script" )} + label=${this.hass.localize( + "ui.panel.config.script.editor.save_script" + )} @click=${this._saveScript} class=${classMap({ dirty: this._dirty, diff --git a/src/panels/config/script/ha-script-picker.ts b/src/panels/config/script/ha-script-picker.ts index 3dc94b280c46..0248b214fcde 100644 --- a/src/panels/config/script/ha-script-picker.ts +++ b/src/panels/config/script/ha-script-picker.ts @@ -152,6 +152,9 @@ class HaScriptPicker extends LitElement { title="${this.hass.localize( "ui.panel.config.script.picker.create_new_script" )}" + label="${this.hass.localize( + "ui.panel.config.script.picker.create_new_script" + )}" ?rtl=${computeRTL(this.hass)} > diff --git a/src/panels/config/tags/ha-config-tags.ts b/src/panels/config/tags/ha-config-tags.ts index 2fbe093f437f..80e9f491948e 100644 --- a/src/panels/config/tags/ha-config-tags.ts +++ b/src/panels/config/tags/ha-config-tags.ts @@ -210,6 +210,7 @@ export class HaConfigTags extends SubscribeMixin(LitElement) { diff --git a/src/panels/config/users/ha-config-users.ts b/src/panels/config/users/ha-config-users.ts index 09ca727a220b..30d87ef2170a 100644 --- a/src/panels/config/users/ha-config-users.ts +++ b/src/panels/config/users/ha-config-users.ts @@ -101,6 +101,7 @@ export class HaConfigUsers extends LitElement { diff --git a/src/panels/config/zone/ha-config-zone.ts b/src/panels/config/zone/ha-config-zone.ts index 6f4f277ab695..9c0c27ea659b 100644 --- a/src/panels/config/zone/ha-config-zone.ts +++ b/src/panels/config/zone/ha-config-zone.ts @@ -258,6 +258,7 @@ export class HaConfigZone extends SubscribeMixin(LitElement) { diff --git a/src/panels/lovelace/views/hui-masonry-view.ts b/src/panels/lovelace/views/hui-masonry-view.ts index 23d9833c4c69..5cdf8c9d3025 100644 --- a/src/panels/lovelace/views/hui-masonry-view.ts +++ b/src/panels/lovelace/views/hui-masonry-view.ts @@ -87,6 +87,9 @@ export class MasonryView extends LitElement implements LovelaceViewElement { title=${this.hass!.localize( "ui.panel.lovelace.editor.edit_card.add" )} + label=${this.hass!.localize( + "ui.panel.lovelace.editor.edit_card.add" + )} @click=${this._addCard} class=${classMap({ rtl: computeRTL(this.hass!), diff --git a/src/panels/lovelace/views/hui-panel-view.ts b/src/panels/lovelace/views/hui-panel-view.ts index e4d34a9831df..f893c2052a43 100644 --- a/src/panels/lovelace/views/hui-panel-view.ts +++ b/src/panels/lovelace/views/hui-panel-view.ts @@ -81,6 +81,9 @@ export class PanelView extends LitElement implements LovelaceViewElement { title=${this.hass!.localize( "ui.panel.lovelace.editor.edit_card.add" )} + label=${this.hass!.localize( + "ui.panel.lovelace.editor.edit_card.add" + )} @click=${this._addCard} class=${classMap({ rtl: computeRTL(this.hass!), From d2007a451d2e7a9171fa6d3d49a32d02d5c3954e Mon Sep 17 00:00:00 2001 From: Philip Allgaier Date: Fri, 6 Nov 2020 22:31:15 +0100 Subject: [PATCH 2/4] Use extended fab + remove duplication of title and label --- src/panels/config/areas/ha-config-areas-dashboard.ts | 6 ++---- src/panels/config/automation/ha-automation-editor.ts | 4 ++-- src/panels/config/automation/ha-automation-picker.ts | 6 ++---- src/panels/config/helpers/ha-config-helpers.ts | 6 ++---- src/panels/config/integrations/ha-config-integrations.ts | 6 ++++-- .../integration-panels/zha/zha-config-dashboard.ts | 4 ++-- .../integration-panels/zha/zha-groups-dashboard.ts | 6 ++++-- .../lovelace/dashboards/ha-config-lovelace-dashboards.ts | 6 ++---- .../lovelace/resources/ha-config-lovelace-resources.ts | 6 ++---- src/panels/config/person/ha-config-person.ts | 4 ++-- src/panels/config/scene/ha-scene-dashboard.ts | 6 ++---- src/panels/config/scene/ha-scene-editor.ts | 4 ++-- src/panels/config/script/ha-script-editor.ts | 6 ++---- src/panels/config/script/ha-script-picker.ts | 8 +++----- src/panels/config/tags/ha-config-tags.ts | 4 ++-- src/panels/config/users/ha-config-users.ts | 4 ++-- src/panels/config/zone/ha-config-zone.ts | 4 ++-- .../editor/unused-entities/hui-unused-entities.ts | 1 + src/panels/lovelace/views/hui-masonry-view.ts | 6 ++---- src/panels/lovelace/views/hui-panel-view.ts | 6 ++---- src/translations/en.json | 2 +- 21 files changed, 45 insertions(+), 60 deletions(-) diff --git a/src/panels/config/areas/ha-config-areas-dashboard.ts b/src/panels/config/areas/ha-config-areas-dashboard.ts index 2c7aba5341e1..a8b35f66c716 100644 --- a/src/panels/config/areas/ha-config-areas-dashboard.ts +++ b/src/panels/config/areas/ha-config-areas-dashboard.ts @@ -126,12 +126,10 @@ export class HaConfigAreasDashboard extends LitElement { > diff --git a/src/panels/config/automation/ha-automation-editor.ts b/src/panels/config/automation/ha-automation-editor.ts index 1d6dbccd9ad8..44e6c34e6c20 100644 --- a/src/panels/config/automation/ha-automation-editor.ts +++ b/src/panels/config/automation/ha-automation-editor.ts @@ -472,8 +472,8 @@ export class HaAutomationEditor extends KeyboardShortcutMixin(LitElement) { diff --git a/src/panels/config/automation/ha-automation-picker.ts b/src/panels/config/automation/ha-automation-picker.ts index c26160a9c382..9c4acf92cc9e 100644 --- a/src/panels/config/automation/ha-automation-picker.ts +++ b/src/panels/config/automation/ha-automation-picker.ts @@ -176,12 +176,10 @@ class HaAutomationPicker extends LitElement { diff --git a/src/panels/config/helpers/ha-config-helpers.ts b/src/panels/config/helpers/ha-config-helpers.ts index b97b83f5d266..3e3db77b53d4 100644 --- a/src/panels/config/helpers/ha-config-helpers.ts +++ b/src/panels/config/helpers/ha-config-helpers.ts @@ -160,12 +160,10 @@ export class HaConfigHelpers extends LitElement { > diff --git a/src/panels/config/integrations/ha-config-integrations.ts b/src/panels/config/integrations/ha-config-integrations.ts index 615e075f05d4..3ce52f210df7 100644 --- a/src/panels/config/integrations/ha-config-integrations.ts +++ b/src/panels/config/integrations/ha-config-integrations.ts @@ -475,8 +475,10 @@ class HaConfigIntegrations extends SubscribeMixin(LitElement) { diff --git a/src/panels/config/integrations/integration-panels/zha/zha-config-dashboard.ts b/src/panels/config/integrations/integration-panels/zha/zha-config-dashboard.ts index bb854a7ad790..e6025f777c45 100644 --- a/src/panels/config/integrations/integration-panels/zha/zha-config-dashboard.ts +++ b/src/panels/config/integrations/integration-panels/zha/zha-config-dashboard.ts @@ -84,8 +84,8 @@ class ZHAConfigDashboard extends LitElement { diff --git a/src/panels/config/integrations/integration-panels/zha/zha-groups-dashboard.ts b/src/panels/config/integrations/integration-panels/zha/zha-groups-dashboard.ts index 0b413954aa02..3ece6f2a7cd2 100644 --- a/src/panels/config/integrations/integration-panels/zha/zha-groups-dashboard.ts +++ b/src/panels/config/integrations/integration-panels/zha/zha-groups-dashboard.ts @@ -128,8 +128,10 @@ export class ZHAGroupsDashboard extends LitElement { > diff --git a/src/panels/config/lovelace/dashboards/ha-config-lovelace-dashboards.ts b/src/panels/config/lovelace/dashboards/ha-config-lovelace-dashboards.ts index a18b88b537d3..80d9c7819649 100644 --- a/src/panels/config/lovelace/dashboards/ha-config-lovelace-dashboards.ts +++ b/src/panels/config/lovelace/dashboards/ha-config-lovelace-dashboards.ts @@ -225,12 +225,10 @@ export class HaConfigLovelaceDashboards extends LitElement { > diff --git a/src/panels/config/lovelace/resources/ha-config-lovelace-resources.ts b/src/panels/config/lovelace/resources/ha-config-lovelace-resources.ts index 9c82699dfc2d..77d77f73e206 100644 --- a/src/panels/config/lovelace/resources/ha-config-lovelace-resources.ts +++ b/src/panels/config/lovelace/resources/ha-config-lovelace-resources.ts @@ -105,12 +105,10 @@ export class HaConfigLovelaceRescources extends LitElement { > diff --git a/src/panels/config/person/ha-config-person.ts b/src/panels/config/person/ha-config-person.ts index d23d1af5c7dc..13fc17dd7655 100644 --- a/src/panels/config/person/ha-config-person.ts +++ b/src/panels/config/person/ha-config-person.ts @@ -148,8 +148,8 @@ class HaConfigPerson extends LitElement { diff --git a/src/panels/config/scene/ha-scene-dashboard.ts b/src/panels/config/scene/ha-scene-dashboard.ts index 27a06b7a10de..036f428f5f43 100644 --- a/src/panels/config/scene/ha-scene-dashboard.ts +++ b/src/panels/config/scene/ha-scene-dashboard.ts @@ -153,12 +153,10 @@ class HaSceneDashboard extends LitElement { diff --git a/src/panels/config/scene/ha-scene-editor.ts b/src/panels/config/scene/ha-scene-editor.ts index 22336ef9c95b..d06ddce67640 100644 --- a/src/panels/config/scene/ha-scene-editor.ts +++ b/src/panels/config/scene/ha-scene-editor.ts @@ -405,8 +405,8 @@ export class HaSceneEditor extends SubscribeMixin( diff --git a/src/panels/config/script/ha-script-editor.ts b/src/panels/config/script/ha-script-editor.ts index efaf022a2fbc..00dc89bca59c 100644 --- a/src/panels/config/script/ha-script-editor.ts +++ b/src/panels/config/script/ha-script-editor.ts @@ -367,12 +367,10 @@ export class HaScriptEditor extends KeyboardShortcutMixin(LitElement) { diff --git a/src/panels/config/tags/ha-config-tags.ts b/src/panels/config/tags/ha-config-tags.ts index 80e9f491948e..fb3293dace7f 100644 --- a/src/panels/config/tags/ha-config-tags.ts +++ b/src/panels/config/tags/ha-config-tags.ts @@ -209,8 +209,8 @@ export class HaConfigTags extends SubscribeMixin(LitElement) { diff --git a/src/panels/config/users/ha-config-users.ts b/src/panels/config/users/ha-config-users.ts index 30d87ef2170a..2a0139030fad 100644 --- a/src/panels/config/users/ha-config-users.ts +++ b/src/panels/config/users/ha-config-users.ts @@ -100,8 +100,8 @@ export class HaConfigUsers extends LitElement { > diff --git a/src/panels/config/zone/ha-config-zone.ts b/src/panels/config/zone/ha-config-zone.ts index 9c0c27ea659b..36bae59ae8d3 100644 --- a/src/panels/config/zone/ha-config-zone.ts +++ b/src/panels/config/zone/ha-config-zone.ts @@ -257,8 +257,8 @@ export class HaConfigZone extends SubscribeMixin(LitElement) { : ""} diff --git a/src/panels/lovelace/editor/unused-entities/hui-unused-entities.ts b/src/panels/lovelace/editor/unused-entities/hui-unused-entities.ts index 8a500d2499d2..d9e0ea7b77d4 100644 --- a/src/panels/lovelace/editor/unused-entities/hui-unused-entities.ts +++ b/src/panels/lovelace/editor/unused-entities/hui-unused-entities.ts @@ -110,6 +110,7 @@ export class HuiUnusedEntities extends LitElement { > diff --git a/src/panels/lovelace/views/hui-masonry-view.ts b/src/panels/lovelace/views/hui-masonry-view.ts index 5cdf8c9d3025..6fa5a249f056 100644 --- a/src/panels/lovelace/views/hui-masonry-view.ts +++ b/src/panels/lovelace/views/hui-masonry-view.ts @@ -84,12 +84,10 @@ export class MasonryView extends LitElement implements LovelaceViewElement { ${this.lovelace?.editMode ? html` Date: Fri, 6 Nov 2020 22:35:47 +0100 Subject: [PATCH 3/4] Changes from review --- src/panels/config/helpers/ha-config-helpers.ts | 4 ++-- .../lovelace/dashboards/ha-config-lovelace-dashboards.ts | 4 ++-- src/panels/config/person/ha-config-person.ts | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/panels/config/helpers/ha-config-helpers.ts b/src/panels/config/helpers/ha-config-helpers.ts index 3e3db77b53d4..68da162f1cf2 100644 --- a/src/panels/config/helpers/ha-config-helpers.ts +++ b/src/panels/config/helpers/ha-config-helpers.ts @@ -160,9 +160,9 @@ export class HaConfigHelpers extends LitElement { > diff --git a/src/panels/config/lovelace/dashboards/ha-config-lovelace-dashboards.ts b/src/panels/config/lovelace/dashboards/ha-config-lovelace-dashboards.ts index 80d9c7819649..a0dd5f05dcee 100644 --- a/src/panels/config/lovelace/dashboards/ha-config-lovelace-dashboards.ts +++ b/src/panels/config/lovelace/dashboards/ha-config-lovelace-dashboards.ts @@ -225,9 +225,9 @@ export class HaConfigLovelaceDashboards extends LitElement { > diff --git a/src/panels/config/person/ha-config-person.ts b/src/panels/config/person/ha-config-person.ts index 13fc17dd7655..b1f40224d139 100644 --- a/src/panels/config/person/ha-config-person.ts +++ b/src/panels/config/person/ha-config-person.ts @@ -148,7 +148,7 @@ class HaConfigPerson extends LitElement { From 4095a734e7059593c8280e423554f87c736f481c Mon Sep 17 00:00:00 2001 From: Philip Allgaier Date: Fri, 6 Nov 2020 22:38:24 +0100 Subject: [PATCH 4/4] More changes from review --- src/panels/config/areas/ha-config-areas-dashboard.ts | 4 ++-- src/panels/config/script/ha-script-picker.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/panels/config/areas/ha-config-areas-dashboard.ts b/src/panels/config/areas/ha-config-areas-dashboard.ts index a8b35f66c716..b9de85cb2710 100644 --- a/src/panels/config/areas/ha-config-areas-dashboard.ts +++ b/src/panels/config/areas/ha-config-areas-dashboard.ts @@ -126,9 +126,9 @@ export class HaConfigAreasDashboard extends LitElement { > diff --git a/src/panels/config/script/ha-script-picker.ts b/src/panels/config/script/ha-script-picker.ts index bc23e54ea864..ac52705a39b9 100644 --- a/src/panels/config/script/ha-script-picker.ts +++ b/src/panels/config/script/ha-script-picker.ts @@ -149,9 +149,9 @@ class HaScriptPicker extends LitElement {