From e6fbe11a39b5e17d7e12071d7b75c875e9942a6c Mon Sep 17 00:00:00 2001 From: Bram Kragten Date: Thu, 12 Mar 2020 14:42:44 +0100 Subject: [PATCH 1/2] Fix resize observer on error card --- src/panels/lovelace/cards/hui-media-control-card.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/panels/lovelace/cards/hui-media-control-card.ts b/src/panels/lovelace/cards/hui-media-control-card.ts index c25a356e3461..219922b48993 100644 --- a/src/panels/lovelace/cards/hui-media-control-card.ts +++ b/src/panels/lovelace/cards/hui-media-control-card.ts @@ -506,7 +506,7 @@ export class HuiMediaControlCard extends LitElement implements LovelaceCard { this._cardHeight = card.offsetHeight; } - private _attachObserver(): void { + private async _attachObserver(): Promise { if (typeof ResizeObserver !== "function") { import("resize-observer").then((modules) => { modules.install(); @@ -519,7 +519,12 @@ export class HuiMediaControlCard extends LitElement implements LovelaceCard { debounce(() => this._measureCard(), 250, false) ); - this._resizeObserver.observe(this.shadowRoot!.querySelector("ha-card")!); + const card = this.shadowRoot!.querySelector("ha-card"); + // If we show an error or warning there is no ha-card + if (!card) { + return; + } + this._resizeObserver.observe(card); } private _handleMoreInfo(): void { From 497ac54deeed61dd489a99086254164b021f20af Mon Sep 17 00:00:00 2001 From: Bram Kragten Date: Thu, 12 Mar 2020 15:55:57 +0100 Subject: [PATCH 2/2] Update hui-media-control-card.ts --- src/panels/lovelace/cards/hui-media-control-card.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/panels/lovelace/cards/hui-media-control-card.ts b/src/panels/lovelace/cards/hui-media-control-card.ts index 219922b48993..1d03d4917d31 100644 --- a/src/panels/lovelace/cards/hui-media-control-card.ts +++ b/src/panels/lovelace/cards/hui-media-control-card.ts @@ -506,7 +506,7 @@ export class HuiMediaControlCard extends LitElement implements LovelaceCard { this._cardHeight = card.offsetHeight; } - private async _attachObserver(): Promise { + private _attachObserver(): void { if (typeof ResizeObserver !== "function") { import("resize-observer").then((modules) => { modules.install();