Skip to content

Change map settings icon#4701

Merged
balloob merged 2 commits into
devfrom
change-map-setting-icon
Feb 1, 2020
Merged

Change map settings icon#4701
balloob merged 2 commits into
devfrom
change-map-setting-icon

Conversation

@bramkragten
Copy link
Copy Markdown
Member

@bramkragten bramkragten commented Jan 31, 2020

Closes #4694
Fixes #4702

@iantrich
Copy link
Copy Markdown
Member

My vote would be for mdi:map-marker-radius. @SeanPM5 reasoning, as that is already the Zones icon, makes sense to me.

@SeanPM5
Copy link
Copy Markdown
Contributor

SeanPM5 commented Jan 31, 2020

I think there's two ways of looking at it.

Brand new users would likely experience the Map panel first, simply because that's the topmost sidebar item after Lovelace. So they wouldn't necessarily be familiar with the config dash / Zones panel icon yet. Pencil icon might be a little quicker to grasp for newbies?

Existing users who are more familiar with the panels would maybe prefer it uses the Zones icon though? I don't have a strong preference on this, either choice would be fine imo.

@bramkragten
Copy link
Copy Markdown
Member Author

I prefer the pencil as it is in line with the scene/automation/script buttons in the more info

@balloob balloob merged commit f5dec3c into dev Feb 1, 2020
@delete-merged-branch delete-merged-branch Bot deleted the change-map-setting-icon branch February 1, 2020 08:26
@lock lock Bot locked and limited conversation to collaborators Feb 2, 2020
@bramkragten bramkragten added this to the 0.105 milestone Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide Zone link from Map panel on Demo Change settings icon on Map panel

5 participants