Fix action directive double tab iOS issues#4639
Merged
Merged
Conversation
Member
|
I think our tabindex checks are for tap_action only. We'll want to revise those to check if double_tap_action is defined as well now. |
iantrich
approved these changes
Jan 29, 2020
This was referenced Jan 29, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes firing double click when clicking on iOS and adds support for double enters.
We ignore all events that are not from the same kind as the original event, so if the first event is touch, we ignore all mouse events and the other way around.
Fixes #4419