Add area picker#4608
Merged
Merged
Conversation
balloob
reviewed
Jan 25, 2020
| private _areaChanged(ev: PolymerChangedEvent<string>) { | ||
| const newValue = ev.detail.value; | ||
|
|
||
| if (newValue === "add_new") { |
Member
There was a problem hiding this comment.
FYI, if you have a large IF-block at which you return at the end, and then have a small if-block, you can better reverse them and then have less indentation. Easier to follow.
if (newValue !== "add_new") {
if (newValue !== this._value) {
this._setValue(newValue);
}
return;
}
balloob
reviewed
Jan 25, 2020
| css` | ||
| ha-paper-dialog { | ||
| max-width: 500px; | ||
| max-width: 600px; |
Member
There was a problem hiding this comment.
I know why you did this, but I think for a future PR we should just convert the grid to a single list. Left side name/manufactuer/model, right side area. I'll open an issue for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: