Skip to content

Improve zones UI#4576

Merged
bramkragten merged 10 commits into
devfrom
zone-ui-improv
Jan 24, 2020
Merged

Improve zones UI#4576
bramkragten merged 10 commits into
devfrom
zone-ui-improv

Conversation

@bramkragten
Copy link
Copy Markdown
Member

@bramkragten bramkragten commented Jan 23, 2020

closes #4574
fixes #4565
fixes #4573

@bramkragten bramkragten requested a review from balloob January 23, 2020 19:44
@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 24, 2020

  • Wondering if we need to hide the config sidebar to give more space to the map?
  • Clicking on a zone on the right will not fit it to the map. We should fit it in the map + some space around it (or it's a full orange page)
  • Map still resets when I'm editing in the edit dialog
  • Can we add a tooltip when hovering the disabled flow rows with why it won't work.

@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 24, 2020

Can we text-align: center the zone name.

image

@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 24, 2020

Tapping the home zone name shouldn't show an alert. Just the edit icon.

@bramkragten
Copy link
Copy Markdown
Member Author

bramkragten commented Jan 24, 2020

Map still resets when I'm editing in the edit dialog

Not seeing this? When do you get that?

@bramkragten
Copy link
Copy Markdown
Member Author

bramkragten commented Jan 24, 2020

Wondering if we need to hide the config sidebar to give more space to the map?

I don't know... let's keep that for another PR (or another nav 😄 )

Edit: Ok I did it, it feels a little weird as the back button no longer goes to config dashboard when you came from a different config page...

@bramkragten bramkragten merged commit b7a3fe6 into dev Jan 24, 2020
@delete-merged-branch delete-merged-branch Bot deleted the zone-ui-improv branch January 24, 2020 22:21
@lock lock Bot locked and limited conversation to collaborators Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New zone form polishing Creating Zone: Any change to data (including dragging zone) centers zone Zone panel looks weird when empty

3 participants