Skip to content

Add zones config UI#4556

Merged
balloob merged 7 commits into
devfrom
zone-ui
Jan 22, 2020
Merged

Add zones config UI#4556
balloob merged 7 commits into
devfrom
zone-ui

Conversation

@bramkragten
Copy link
Copy Markdown
Member

@bramkragten bramkragten commented Jan 22, 2020

Needs home-assistant/core#30774

image
image
^ I did change that passive toggle text before commiting ;-)

@bramkragten bramkragten requested a review from balloob January 22, 2020 11:00
@SeanPM5
Copy link
Copy Markdown
Contributor

SeanPM5 commented Jan 22, 2020

Looks awesome! 🎉

One idea / suggestion to consider later on, I think radius would probably benefit from being a slider?

Feels easier to just drag a slider left or right and watch as the radius on the map grows or shrinks, rather than the tedious trial-and-error of constantly tweaking values in a text field. Especially for mobile devices where the keyboard will take up half your screen.

@bramkragten
Copy link
Copy Markdown
Member Author

bramkragten commented Jan 22, 2020

It should just be draggable like it is in the main view, that's something I have to add still.
You can resize the radius by dragging the white circle on the orange radius

The problem with the slider is the scale, you cant do precious adjustments with a big scale and can't make the radius big if it isn't

Comment thread src/components/map/ha-location-editor.ts
Comment thread src/panels/config/zone/dialog-zone-detail.ts Outdated
Comment thread src/panels/config/zone/dialog-zone-detail.ts Outdated
Comment thread src/panels/config/zone/dialog-zone-detail.ts Outdated
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

Amazing.

@balloob balloob merged commit 49611e2 into dev Jan 22, 2020
@delete-merged-branch delete-merged-branch Bot deleted the zone-ui branch January 22, 2020 19:29
@lock lock Bot locked and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants