add never_triggered

[Mariusthvdb]

Add never_triggered to the last-triggered secondary_info.
as it stands, the secondary_info line is empty when used on an automation or script that hasn't been triggered yet, while the user expects info on that line.

my suggestion would be to add:

"automation": {
        "last_triggered": "Last triggered",
        "never_triggered":"Never triggered",
        "trigger": "Execute"
      }

and

"script": {
        "last_triggered": "Last triggered",
        "never_triggered":"Never triggered",
        "execute": "Execute"
      }

to the translation file.

[Mariusthvdb]

thanks for your feedback, appreciated!

[iantrich]

Remove these two. You are not using them.

[bramkragten]

Please also test your PR

[Mariusthvdb]

Please also test your PR

ok let me know how?

[bramkragten]

Follow these instructions: https://developers.home-assistant.io/docs/en/frontend_development.html

[Mariusthvdb]

That is a bit overtaxing at the moment I fear... setting up a full development environment I wouldn't know where to start with, for such a small edit..
Hope to have a spare device for that anytime soon, please have patience.

[Mariusthvdb]

@bramkragten
having some difficulties setting up my dev environment, which won't go beyond setting up an integration (Sonos) and doesn't finish the full startup sequence... because of this, I can't set up any testing yet I fear. Is there any way you guys can test if this works now, so we can proceed with the PR?

[ludeeus]

Tested, it does not work, probably needs a check against null and/or undefined.
When you get your env up and running, you will probably find it :)

[Mariusthvdb]

a check is what I had in my first suggestion, which was later on superseded with Ian 's code.

what would be best? to first check if not null? like

              : this.config.secondary_info === "last-triggered" &&
                 stateObj.attributes.last_triggered !== null
                 ? html`
                     <ha-relative-time
                       .hass=${this.hass}
                       .datetime=${stateObj.attributes.last_triggered}
                     ></ha-relative-time>
                   `
                 : this.hass.localize(
                     "ui.panel.lovelace.card.entities.never_triggered"
                   )

or should it be:

              : this.config.secondary_info === "last-triggered"
              ? stateObj.attributes.last_triggered !== null
                 ? html`
                     <ha-relative-time
                       .hass=${this.hass}
                       .datetime=${stateObj.attributes.last_triggered}
                     ></ha-relative-time>
                   `
                 : this.hass.localize(
                     "ui.panel.lovelace.card.entities.never_triggered"
                   )

[bramkragten]

Probably the second with a falsy check instead of null (as you now don't catch undefined)

[Mariusthvdb]

since this is new to me, I'm not sure what I should add. Checked all never_triggered automations and scripts in HA states, and in template editor.

In states they all show last_triggered: null, while in templates attributes_last_triggered == None or none. Never unknown or null.

If that still leaves you needing an extra falsy check, please let me know what that would need to be besides testing for !== null

[iantrich]

The problem is not the check it is your translation path. You added your translation to ui.panel.lovelace.editor.entities.never_triggered in en.json

[Mariusthvdb]

wow, thanks Ian, really appreciated!
was seriously confused by all of this, yet so simple....
glad it is finally approved!
anything else left for Merge?