Skip to content

Make entry flow dialog modal#4440

Merged
balloob merged 4 commits into
devfrom
entry-flow-dialog
Jan 11, 2020
Merged

Make entry flow dialog modal#4440
balloob merged 4 commits into
devfrom
entry-flow-dialog

Conversation

@bramkragten
Copy link
Copy Markdown
Member

@bramkragten bramkragten commented Jan 8, 2020 •
edited
Loading

image

@bramkragten
Copy link
Copy Markdown
Member Author

bramkragten commented Jan 9, 2020

This is not good, as the entry flow dialog doesn't have a close or cancel button the only way to close it was a click outside the dialog.

@balloob balloob merged commit 5a172a6 into dev Jan 11, 2020
@delete-merged-branch delete-merged-branch Bot deleted the entry-flow-dialog branch January 11, 2020 00:40
@lock lock Bot locked and limited conversation to collaborators Jan 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob approved these changes

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bramkragten @balloob @homeassistant