Skip to content

Change config panel navigation#4377

Merged
bramkragten merged 6 commits into
devfrom
config-navigation
Jan 12, 2020
Merged

Change config panel navigation#4377
bramkragten merged 6 commits into
devfrom
config-navigation

Conversation

@bramkragten
Copy link
Copy Markdown
Member

The way we used the available space in the config panel was a bit useless at a lot of places so I thought we could use if for better things.

When we have enough space we now show the config navigation on the left.

It can use more fine tuning, this is a start.

image

@frenck
Copy link
Copy Markdown
Member

frenck commented Dec 23, 2019

❤️ Love it!

Maybe not for now, but we could consider adding icons to each item in the list, which makes is visually recognizable.

@bramkragten
Copy link
Copy Markdown
Member Author

Yeah that would be nice, have to make sure there stays enough room for the content though, especially the data tables need the horizontal space.

@balloob
Copy link
Copy Markdown
Member

balloob commented Dec 24, 2019

Can we make the menu component be shown underneath the toolbar of the page? So automations is above the menu. And we highlight the current section?

@balloob
Copy link
Copy Markdown
Member

balloob commented Dec 24, 2019

Or, we drop the toolbar sharing between menu and content completely. Make the page really stand on their own

@balloob
Copy link
Copy Markdown
Member

balloob commented Dec 24, 2019

Like, start with dropping the automations toolbar first. Since there is a title underneath, should look ok?

@bramkragten
Copy link
Copy Markdown
Member Author

Like this?

image

(btw Automatiseringsbewerker really?)

@bramkragten
Copy link
Copy Markdown
Member Author

Not a fan of dropping the toolbar, it gets messy with subpages, etc.

@iantrich
Copy link
Copy Markdown
Member

iantrich commented Jan 9, 2020

Not sure how I feel about this. The sidebar | config nav seem to conflict with each other. I assume this wouldn't show if I had the sidebar expanded?

@bramkragten
Copy link
Copy Markdown
Member Author

Depends how wide your screen is right now, if we have the space we do

@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 11, 2020

Something like that, but drop the blue and align the word "Configuration" with the text in the menu. No need to draw attention to something that's not important.

@SeanPM5
Copy link
Copy Markdown
Contributor

SeanPM5 commented Jan 11, 2020

Here's another potential idea / mockup tweaked from the screenshot in OP. This keeps the toolbar intact but tweaks the left config navigation a little bit.

Changed the background color to match with the hamburger menu so it no longer sticks out, centered the "Configuration" text, and added a subtle breadcrumb icon (mdi:chevron-right-circle) to indicate the hierarchy. Also made the active panel have bold text.

image

@bramkragten
Copy link
Copy Markdown
Member Author

Not sure about that arrow, feels like something I could click on?

@bramkragten
Copy link
Copy Markdown
Member Author

image

@iantrich
Copy link
Copy Markdown
Member

I would ditch the blue and just have a header like you do in the list of possible configs like you did here and align it left

@SeanPM5
Copy link
Copy Markdown
Contributor

SeanPM5 commented Jan 11, 2020

Not sure about that arrow, feels like something I could click on?

Yeah, agreed. Was going for a breadcrumbs-style look and thought it'd be kinda neat if the design reflected how people actually talk about it (the docs for example saying "Go to Configuration > Automation" etc). But you're right, that arrow would probably just confuse people into thinking it's a clickable button.

I do like your latest revision.

I'm not convinced the blue toolbar should be dropped, it's there for literally every other section. I think it'd feel a bit weird and inconsistent if it's gone from just this one place? Makes it feel kinda like a bug or that the page didn't load properly IMO. Also people like to theme their HA and now it wouldn't be using their colors if they had a larger width? Not sure about that.

@iantrich
Copy link
Copy Markdown
Member

I'm not convinced the blue toolbar should be dropped, it's there for literally every other section. I think it'd feel a bit weird and inconsistent if it's gone from just this one place? Makes it feel kinda like a bug or that the page didn't load properly IMO. Also people like to theme their HA and now it wouldn't be using their colors if they had a larger width? Not sure about that.

yeah, i think you're right

Comment thread src/layouts/hass-subpage.ts Outdated
Comment thread src/layouts/hass-subpage.ts Outdated
</style>
<hass-subpage header="[[localize('ui.panel.config.cloud.caption')]]">
<hass-subpage
back="[[!isWide]]"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
back="[[!isWide]]"
.back="[[!isWide]]"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polymer

<hass-subpage header="[[localize('ui.panel.config.cloud.caption')]]">
<hass-subpage
back="[[!isWide]]"
header="[[localize('ui.panel.config.cloud.caption')]]"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
header="[[localize('ui.panel.config.cloud.caption')]]"
.header="[[localize('ui.panel.config.cloud.caption')]]"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polymer

</style>
<hass-subpage header="[[localize('ui.panel.config.cloud.caption')]]">
<hass-subpage
back="[[!isWide]]"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

props

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polymer


<hass-subpage header="[[localize('ui.panel.config.core.caption')]]">
<hass-subpage
header="[[localize('ui.panel.config.core.caption')]]"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

props

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polymer

Comment thread src/panels/config/ha-config-router.ts Outdated
Comment thread src/panels/config/person/ha-config-person.ts Outdated
Comment thread src/panels/config/scene/ha-scene-dashboard.ts Outdated
@bramkragten
Copy link
Copy Markdown
Member Author

Does any one know if this will work?
image

@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 12, 2020

Add the whole prefix to both the search and replace values.

@bramkragten bramkragten merged commit 22792c7 into dev Jan 12, 2020
@delete-merged-branch delete-merged-branch Bot deleted the config-navigation branch January 12, 2020 16:57
@bramkragten bramkragten mentioned this pull request Jan 29, 2020
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants